[PATCH] D44525: [sanitizer] Add a slim Scudo shared runtime

[Kostya Kortchinsky via Phabricator via llvm-commits]

cryptoad added inline comments.


================
Comment at: lib/sanitizer_common/CMakeLists.txt:99
+  sanitizer_procmaps_common.cc
+  sanitizer_procmaps_linux.cc)
+
----------------
eugenis wrote:
> That's unfortunate that this is not a subset of any other source list. I'm worried that people will forget to update it, and would not know whether a new file belongs here or not. It's probably OK as long as scudo_minimal is built by default in compiler-rt.
> 
> AFAIR @pcc mentioned that _libcdep / _nolibc distinction can be deprecated. Is that true? If those are merged into a single source list, would this new SCUDO list be a subset of it?
I am currently trying to do some splits locally, which would make more sense that this version.
The coverage related files can end up in their own `RTSanitizerCommonCoverage` rule so far successfully.
Right now I am battling with the symbolizer/stacktrace files that are more intertwined, trying to have them in a `RTSanitizerCommonSymbolizer` rule.
As far I can see, Safestack is the only consummer of the nolibc part, and is also part of the headache.


================
Comment at: lib/scudo/scudo_override.cpp:22
+    unsigned int coverage_max_block_size;
+} __sanitizer_sandbox_arguments;
+
----------------
eugenis wrote:
> #include "sanitizer_common/sanitizer_interface_internal.h" ?
IIRC I tried but said include defines __sanitizer_sandbox_on_notify as weak and it doesn't override the the function.
In my local copy I ended up with a `void *args` since it's `extern "C"` anyway.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D44525