[PATCH] D44525: [sanitizer] Add a slim Scudo shared runtime

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis added a subscriber: pcc.
eugenis added inline comments.


================
Comment at: lib/sanitizer_common/CMakeLists.txt:99
+  sanitizer_procmaps_common.cc
+  sanitizer_procmaps_linux.cc)
+
----------------
That's unfortunate that this is not a subset of any other source list. I'm worried that people will forget to update it, and would not know whether a new file belongs here or not. It's probably OK as long as scudo_minimal is built by default in compiler-rt.

AFAIR @pcc mentioned that _libcdep / _nolibc distinction can be deprecated. Is that true? If those are merged into a single source list, would this new SCUDO list be a subset of it?


================
Comment at: lib/sanitizer_common/CMakeLists.txt:234
+  ${OS_OPTION}
+  ARCHS ${SANITIZER_COMMON_SUPPORTED_ARCH}
+  SOURCES ${SANITIZER_SCUDO_SOURCES}
----------------
cryptoad wrote:
> So this is not entirely correct as this should probably be `SCUDO_SUPPORTED_ARCH`, but I am not sure I want to mix in both.
This looks fine to me - this library should be buildable for all of $SANITIZER_COMMON_SUPPORTED_ARCH.


================
Comment at: lib/scudo/scudo_override.cpp:22
+    unsigned int coverage_max_block_size;
+} __sanitizer_sandbox_arguments;
+
----------------
#include "sanitizer_common/sanitizer_interface_internal.h" ?


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D44525