[PATCH] D44549: allow-multiple-definitions should completely suppress errors instead of making them warnings.

[Rafael Avila de Espindola via Phabricator via llvm-commits]

espindola added inline comments.


================
Comment at: lld/ELF/SymbolTable.cpp:420
-
-static void reportDuplicate(Symbol *Sym, InputFile *NewFile) {
-  warnOrError("duplicate symbol: " + toString(*Sym) + "\n>>> defined in " +
----------------
ruiu wrote:
> espindola wrote:
> > Why was it necessary to inline this reportDuplicate?
> It's not necessary, but since it is now short that it is easier to read than having a overloaded function.
Leave that for a followup patch. There may be a better way of merging these two overloads and doing it in one patch makes the patch harder to read.


https://reviews.llvm.org/D44549