[PATCH] D44549: allow-multiple-definitions should completely suppress errors instead of making them warnings.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: lld/ELF/SymbolTable.cpp:420
-
-static void reportDuplicate(Symbol *Sym, InputFile *NewFile) {
-  warnOrError("duplicate symbol: " + toString(*Sym) + "\n>>> defined in " +
----------------
espindola wrote:
> Why was it necessary to inline this reportDuplicate?
It's not necessary, but since it is now short that it is easier to read than having a overloaded function.


https://reviews.llvm.org/D44549