[PATCH] D7775: [IR] Avoid the need to prefix MS C++ symbols with '\01'

[Rafael Avila de Espindola via Phabricator via llvm-commits]

espindola added a comment.

In https://reviews.llvm.org/D7775#1039687, @rnk wrote:

> I guess the only consideration is, are we ready for clang to emit "_malloc", "_main", and "_printf". I'm not sure I have the consensus to make that change.


If I recall correctly, last time the only objection was from the MachO camp. Since the mangling mode is part of the datalayout now, we could leave MachO alone which would already at least simplify the implementation.

> I would say this is at least an incremental step towards that. After this, I will update all the Clang IRGen test cases to not expect the '\01' escape for MS ABI code. Then there will be fewer cases to update when we eventually get consensus to go to MM_None. Reasonable?

Yes, I am sold. I am taking a look at the implementation.


https://reviews.llvm.org/D7775