[PATCH] D7775: [IR] Avoid the need to prefix MS C++ symbols with '\01'

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

I guess the only consideration is, are we ready for clang to emit "_malloc", "_main", and "_printf". I'm not sure I have the consensus to make that change.

Clang already does the __fastcall etc mangling in the frontend. It would be nice to not have to add escapes there as well. As long as we have these escapes, there will be bugs.

I doubt there are any other frontends that care about the fastcall mangling, and we can provide this API if they want to reuse our mangling logic.

I would say this is at least an incremental step towards that. After this, I will update all the Clang IRGen test cases to not expect the '\01' escape for MS ABI code. Then there will be fewer cases to update when we eventually get consensus to go to MM_None. Reasonable?


https://reviews.llvm.org/D7775