[PATCH] D44538: [ARM] Support for v4f16 and v8f16 vectors

[Tim Northover via Phabricator via llvm-commits]

t.p.northover added a comment.

It looks like there's nothing testing the bitconvert patterns here.

Also, as a general question, didn't the Clang changes go in (and get reverted) before this? That seems pretty dodgy to me; I'm not entirely happy about having user-visible but broken intrinsics in arm_acle.h.



================
Comment at: lib/Target/ARM/ARMInstrNEON.td:7020
   def : Pat<(v2f64 (bitconvert (v8i16 QPR:$src))), (v2f64 QPR:$src)>;
+  def : Pat<(v2f64 (bitconvert (v8f16 QPR:$src))), (v2f64 QPR:$src)>;
   def : Pat<(v2f64 (bitconvert (v16i8 QPR:$src))), (v2f64 QPR:$src)>;
----------------
I know big-endian is a pain in the neck that hardly anyone actually uses, but we probably shouldn't just let it bit-rot


https://reviews.llvm.org/D44538