[PATCH] D44538: [ARM] Support for v4f16 and v8f16 vectors

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added a comment.

Hi Tim,
Thanks for your comments. I will try to answer your general question first (if I understand that correctly).
There should be no dodgy business going on here. I am trying to avoid exactly that, and  I've reverted the 
Clang and user visible part when that showed problems in testing.  Please note that this reverted the
A32 intrinsics, the A64 are still in and should be okay. The FP16 A32 intrinsics were behaving as expected, 
but there was some interaction with existing intrinsics and __fp16. The reason for that is that the author 
of the intrinsics patches changed passing vectors of i16 types, to vector of f16s. 
With the user-visible part reverted, I tried fixing the backend first with this patch. But I've just noticed that 
this patch doesn't solve that case, which is obviously what I also tried to achieve here. There are some issues now 
with legalising f16 vectors (when fullfp16 is not enabled).  I am now first going to rethink why we want to pass 
f16 vectors instead of sticking to i16s..
Cheers.


https://reviews.llvm.org/D44538