[PATCH] D43850: [CodeGen] Avoid handling DBG_VALUE in the LivePhysRegs stepping functions.

Matt Davis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 12 09:08:00 PDT 2018


mattd added a comment.

In https://reviews.llvm.org/D43850#1034803, @bjope wrote:

> If you do not think it is too much trouble, then I'd welcome the alternative approach.




> But skipping early on the MI.isDebugValue() in stepForward/stepBackward is OK as well.
> 
> In case LivePhysRegs::addUses is used from other methods (now or in the future) it would be good to make sure that it ignores isDebug() operands. Or at least add a comment in the method description that any user should make sure to check MI.isDebugValue() before the call.

The only calls to addUses are in LivePhysRegs.cpp, but I'm not opposed to future-proofing.  Let me test out the proposed changes, and if that works out, I'll update this patch.


https://reviews.llvm.org/D43850





More information about the llvm-commits mailing list