[PATCH] D43850: [CodeGen] Avoid handling DBG_VALUE in the LivePhysRegs stepping functions.

Bjorn Pettersson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 12 08:50:08 PDT 2018


bjope added a comment.

If you do not think it is too much trouble, then I'd welcome the alternative approach.
But skipping early on the MI.isDebugValue() in stepForward/stepBackward is OK as well.

In case LivePhysRegs::addUses is used from other methods (now or in the future) it would be good to make sure that it ignores isDebug() operands. Or at least add a comment in the method description that any user should make sure to check MI.isDebugValue() before the call.


https://reviews.llvm.org/D43850





More information about the llvm-commits mailing list