[PATCH] D43838: [CodeView] Initial support for emitting S_THUNK32 symbols for compiler-generated thunk routines

Brock Wyma via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 12 08:43:13 PDT 2018


bwyma marked 3 inline comments as done.
bwyma added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:2430
+  // Thunks are compiler-generated and probably won't have source correlation.
+  if (!CurFn->HaveLineInfo && !GV.getSubprogram()->isThunk()) {
     FnDebugInfo.erase(&GV);
----------------
Some thunks are (correctly) not given any source correlation by CLANG.  When this happens it does not have line info and the entire thunk was being thrown away here.  This change prevents the compiler from throwing away the thunk.


https://reviews.llvm.org/D43838





More information about the llvm-commits mailing list