[PATCH] D43838: [CodeView] Initial support for emitting S_THUNK32 symbols for compiler-generated thunk routines

[Brock Wyma via Phabricator via llvm-commits]

bwyma updated this revision to Diff 138017.
bwyma added a comment.

> Can you add a clang IRGen test that checks the DISubprogram flags set for thunks?

I extended the existing test debug-info-thunk.cpp to make sure the DIFlagThunk flag is set on the thunk routines.

> ... it's worth a comment, either here ...

Comment added.

> I noticed that MSVC emits S_PROC_ID_END. Should we do that too?

Fixed.

> Can you add a member pointer thunk to this test?

Done.


https://reviews.llvm.org/D43838

Files:
  llvm/include/llvm/IR/DebugInfoFlags.def
  llvm/include/llvm/IR/DebugInfoMetadata.h
  llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp
  llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.h
  llvm/lib/DebugInfo/CodeView/SymbolDumper.cpp
  llvm/test/DebugInfo/COFF/thunk.ll
  llvm/tools/clang/lib/CodeGen/CGDebugInfo.cpp
  llvm/tools/clang/lib/CodeGen/CGDebugInfo.h
  llvm/tools/clang/lib/CodeGen/CodeGenFunction.cpp
  llvm/tools/clang/test/CodeGenCXX/debug-info-thunk.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43838.138017.patch
Type: text/x-patch
Size: 53971 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180312/06a647e6/attachment.bin>