[compiler-rt] r327168 - cfi: Disable simple-pass.cpp on Darwin.

[Peter Collingbourne via llvm-commits]

Hi Chandler,

Is -mretpoline expected to work on Darwin? I got an error message on the
Darwin bot:
http://green.lab.llvm.org/green//job/clang-stage1-configure-RA/43450/consoleFull#-1192131881dd1929ea-7054-4089-b7ef-4624c3781fa4
that looked like this:

LLVM ERROR: MachO doesn't support COMDATs, '__llvm_retpoline_eax' cannot be
lowered.

Seems like it should be an easy fix, but I imagine that we should at least
be giving a better error message?

Peter

On Fri, Mar 9, 2018 at 12:41 PM, Peter Collingbourne via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: pcc
> Date: Fri Mar  9 12:41:56 2018
> New Revision: 327168
>
> URL: http://llvm.org/viewvc/llvm-project?rev=327168&view=rev
> Log:
> cfi: Disable simple-pass.cpp on Darwin.
>
> -mretpoline does not work yet on Darwin.
>
> Modified:
>     compiler-rt/trunk/test/cfi/simple-pass.cpp
>
> Modified: compiler-rt/trunk/test/cfi/simple-pass.cpp
> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/
> test/cfi/simple-pass.cpp?rev=327168&r1=327167&r2=327168&view=diff
> ============================================================
> ==================
> --- compiler-rt/trunk/test/cfi/simple-pass.cpp (original)
> +++ compiler-rt/trunk/test/cfi/simple-pass.cpp Fri Mar  9 12:41:56 2018
> @@ -1,3 +1,6 @@
> +// -mretpoline does not work yet on Darwin.
> +// XFAIL: darwin
> +
>  // RUN: %clangxx_cfi -o %t %s
>  // RUN: %run %t
>  // RUN: %clangxx_cfi -mretpoline -o %t2 %s
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>



-- 
-- 
Peter
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180309/0cda191f/attachment.html>