<div dir="ltr">Hi Chandler,<div><br></div><div>Is -mretpoline expected to work on Darwin? I got an error message on the Darwin bot: <span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline"><a href="http://green.lab.llvm.org/green//job/clang-stage1-configure-RA/43450/consoleFull#-1192131881dd1929ea-7054-4089-b7ef-4624c3781fa4">http://green.lab.llvm.org/green//job/clang-stage1-configure-RA/43450/consoleFull#-1192131881dd1929ea-7054-4089-b7ef-4624c3781fa4</a></span></div><div>that looked like this:</div><div><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration-style:initial;text-decoration-color:initial"><div><br></div><div>LLVM ERROR: MachO doesn't support COMDATs, '__llvm_retpoline_eax' cannot be lowered.</div></div></div><div><div><br></div></div><div>Seems like it should be an easy fix, but I imagine that we should at least be giving a better error message?</div><div><br></div><div>Peter </div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Mar 9, 2018 at 12:41 PM, Peter Collingbourne via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: pcc<br>
Date: Fri Mar  9 12:41:56 2018<br>
New Revision: 327168<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=327168&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=327168&view=rev</a><br>
Log:<br>
cfi: Disable simple-pass.cpp on Darwin.<br>
<br>
-mretpoline does not work yet on Darwin.<br>
<br>
Modified:<br>
    compiler-rt/trunk/test/cfi/<wbr>simple-pass.cpp<br>
<br>
Modified: compiler-rt/trunk/test/cfi/<wbr>simple-pass.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/cfi/simple-pass.cpp?rev=327168&r1=327167&r2=327168&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/compiler-rt/trunk/<wbr>test/cfi/simple-pass.cpp?rev=<wbr>327168&r1=327167&r2=327168&<wbr>view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- compiler-rt/trunk/test/cfi/<wbr>simple-pass.cpp (original)<br>
+++ compiler-rt/trunk/test/cfi/<wbr>simple-pass.cpp Fri Mar  9 12:41:56 2018<br>
@@ -1,3 +1,6 @@<br>
+// -mretpoline does not work yet on Darwin.<br>
+// XFAIL: darwin<br>
+<br>
 // RUN: %clangxx_cfi -o %t %s<br>
 // RUN: %run %t<br>
 // RUN: %clangxx_cfi -mretpoline -o %t2 %s<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">-- <div>Peter</div></div></div>
</div>