[PATCH] D44224: [llvm-objdump] Support disassembling by symbol name

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 8 09:19:06 PST 2018


Rafael Auler <rafaelauler at fb.com> writes:

> This is static because the function DisassembleObject potentially runs multiple times. So the static is to avoid re-creating the same set for each object, and it's also why it checks if it is empty.

OK, that is a bit unusual. Please move the set initialization just
before

  llvm::for_each(InputFilenames, DumpInput);

So that it can be done only once by more conventional means. I am OK
with the set being global.

Cheers,
Rafael


More information about the llvm-commits mailing list