[PATCH] D44224: [llvm-objdump] Support disassembling by symbol name

[Rafael Auler via llvm-commits]

This is static because the function DisassembleObject potentially runs multiple times. So the static is to avoid re-creating the same set for each object, and it's also why it checks if it is empty.

On 3/7/18, 5:02 PM, "Rafael Avila de Espindola" <rafael.espindola at gmail.com> wrote:

    Rafael Auler via Phabricator via llvm-commits
    <llvm-commits at lists.llvm.org> writes:
    
    
    > +    static StringSet<> DisasmFuncsSet;
    
    Why static?
    
    > +    if (DisasmFuncsSet.empty() && !DisassembleFunctions.empty())
    
    DisasmFuncsSet has just been created, so it is empty.
    
    Cheers,
    Rafael