[PATCH] D36351: [lld][ELF] Add profile guided section layout

[Rafael Avila de Espindola via llvm-commits]

Rafael Avila de Espindola <rafael.espindola at gmail.com> writes:

>> +    InputSectionBase *FromSec = SymbolSection.lookup(Fields[0]);
>> +    InputSectionBase *ToSec = SymbolSection.lookup(Fields[1]);
>> +    if (FromSec && ToSec)
>> +      Config->CallGraphProfile[std::make_pair(FromSec, ToSec)] = Count;
>
> This should be "+=", no? If there are multiple calls from one section to
> another I would expect us to use the total in the graph.

Looks like the missing + gets us the last missing performance bits.

In the attached log "old" is a rebased version of your previous patch, "new"
is your current patch and "new-new" is your current patch with the above
fix.

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: results.txt
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180306/26587b60/attachment.txt>
-------------- next part --------------


Cheers,
Rafael