[PATCH] D36351: [lld][ELF] Add profile guided section layout

[Rafael Ávila de Espíndola via Phabricator via llvm-commits]

rafael added a comment.

Rafael Avila de Espindola <rafael.espindola at gmail.com> writes:

>> +    InputSectionBase *FromSec = SymbolSection.lookup(Fields[0]);
>>  +    InputSectionBase *ToSec = SymbolSection.lookup(Fields[1]);
>>  +    if (FromSec && ToSec)
>>  +      Config->CallGraphProfile[std::make_pair(FromSec, ToSec)] = Count;
> 
> This should be "+=", no? If there are multiple calls from one section to
>  another I would expect us to use the total in the graph.

Looks like the missing + gets us the last missing performance bits.

In the attached log "old" is a rebased version of your previous patch, "new"
is your current patch and "new-new" is your current patch with the above
fix.

- F5880696: results.txt <https://reviews.llvm.org/F5880696>
- F5880695: msg-17485-242.txt <https://reviews.llvm.org/F5880695>


https://reviews.llvm.org/D36351