[PATCH] D44030: [WebAssembly] Tidy up handling of global symbol relocations
Nicholas Wilson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 2 10:30:01 PST 2018
ncw added inline comments.
Comment at: lib/MC/MCWasmStreamer.cpp:120
This is the only bit I was really unsure about, in terms of whether it breaks anything... currently the "ELF_TypeObject" attribute is set for both `WASM_SYMBOL_TYPE_DATA` and `WASM_SYMBOL_TYPE_GLOBAL` symbols, which is a bit odd. It seems to come from higher-level code that just sets it by default, rather than because we really want that attribute there in our Wasm objects.
More information about the llvm-commits