[PATCH] D44030: [WebAssembly] Tidy up handling of global symbol relocations

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 2 11:18:01 PST 2018


sbc100 added a comment.

Looks good to me.  @sunfish knows this stuff better than me.  I guess the .s file form for -elf won't change at all (since we don't use globals there).. otherwise we could need to fix binaryen (which currently consumes .s).



================
Comment at: lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCTargetDesc.h:91
+// WebAssembly-specific MachineOperand target flags.
+enum WebAssemblyMOTargetFlagVal {
+  MO_NO_FLAG = 0,
----------------
Other platforms seem to call this TOF.  Any reason not to follow suit?


Repository:
  rL LLVM

https://reviews.llvm.org/D44030





More information about the llvm-commits mailing list