[PATCH] D43913: Delay writing the PDB build id until just before file commit.

[Zachary Turner via Phabricator via llvm-commits]

zturner added inline comments.


================
Comment at: lld/COFF/PDB.cpp:1059
   auto &InfoBuilder = Builder.getInfoBuilder();
-  InfoBuilder.setAge(BuildId.PDB70.Age);
-
-  GUID uuid;
-  memcpy(&uuid, &BuildId.PDB70.Signature, sizeof(uuid));
-  InfoBuilder.setGuid(uuid);
-  InfoBuilder.setSignature(time(nullptr));
   InfoBuilder.setVersion(pdb::PdbRaw_ImplVer::PdbImplVC70);
 
----------------
compnerd wrote:
> Can we sink this to the same site too?  I think that the PDB writer indicating what it emitted would be nicer.
We could, but this value is useless for the PE writer and is definitely PDB specific.  It's not part of the build id or anything and is really more of an implementation detail of the PDB, so that's why I left it here.


https://reviews.llvm.org/D43913