[PATCH] D43913: Delay writing the PDB build id until just before file commit.

Saleem Abdulrasool via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 28 15:12:33 PST 2018

compnerd added inline comments.

Comment at: lld/COFF/PDB.cpp:1059
   auto &InfoBuilder = Builder.getInfoBuilder();
-  InfoBuilder.setAge(BuildId.PDB70.Age);
-  GUID uuid;
-  memcpy(&uuid, &BuildId.PDB70.Signature, sizeof(uuid));
-  InfoBuilder.setGuid(uuid);
-  InfoBuilder.setSignature(time(nullptr));
Can we sink this to the same site too?  I think that the PDB writer indicating what it emitted would be nicer.


More information about the llvm-commits mailing list