[PATCH] D43267: MIRParser: Accept overloaded intrinsic names w/o type suffixes

Justin Bogner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 28 11:36:15 PST 2018

bogner accepted this revision.
bogner added a comment.
This revision is now accepted and ready to land.

Looks good, thanks

Comment at: test/CodeGen/MIR/AArch64/print-parse-overloaded-intrinsics.mir:1-3
+# RUN: llc -mtriple aarch64-- -run-pass irtranslator -simplify-mir %s -o - \
+# RUN:   -verify-machineinstrs | llc -mtriple aarch64-- -run-pass legalizer \
+# RUN:   -simplify-mir -x mir -o - -verify-machineinstrs | FileCheck %s
It might be easier to tell what went wrong on failures if we output to a temporary file (ie %t) instead of doing this all in a single pipeline.

Comment at: test/CodeGen/MIR/AArch64/print-parse-overloaded-intrinsics.mir:9-24
+--- |
+  define i32 @int_aarch64_sdiv(i32 %a, i32 %b) nounwind readnone ssp {
+  ; CHECK-LABEL: name: int_aarch64_sdiv
+  ; CHECK: liveins: $w0, $w1
+  ; CHECK: [[COPY:%[0-9]+]]:_(s32) = COPY $w0
+  ; CHECK: [[COPY1:%[0-9]+]]:_(s32) = COPY $w1
+  ; CHECK: [[INT:%[0-9]+]]:_(s32) = G_INTRINSIC intrinsic(@llvm.aarch64.sdiv), [[COPY]](s32), [[COPY1]](s32)
I guess it makes sense since this is a test for the mir parser, but it's a bit odd to have a mir file that only consists of llvm ir.



More information about the llvm-commits mailing list