[PATCH] D43687: Improve merging of debug locations (fixes PR 36410)

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 26 09:02:57 PST 2018

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

> I'm not sure I understand why we should keep two debug intrinsics around in just this case, and not in other cases where the original IR has differing debug intrinsics (e.g. for different variables)?

My assumption was that if the variables were different, this function would not have been called in the first place, since the two instructions were already different. That depends on how the caller of getMergedLocation is implemented of course.

I'm happy with this variant. Perhaps also let dblaikie sign off, since he mentioned in the PR that we also wanted to give this a closer look.



More information about the llvm-commits mailing list