[PATCH] D43687: Improve merging of debug locations (fixes PR 36410)

Ulrich Weigand via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 26 06:36:04 PST 2018


uweigand added a comment.

I'm not sure I understand why we should keep two debug intrinsics around in just this case, and not in other cases where the original IR has differing debug intrinsics (e.g. for different variables)?

But in any case, keeping multiple debug intrinsics would need to be done in HoistThenElseCodeToIf, not here in getMergedLocation.  So I think this should probably be a separate discussion independent of this patch ...


Repository:
  rL LLVM

https://reviews.llvm.org/D43687





More information about the llvm-commits mailing list