[PATCH] D43499: [SCEV] Introduce SCEVPostIncRewriter

Serguei Katkov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 25 21:17:48 PST 2018

skatkov added inline comments.

Comment at: lib/Analysis/ScalarEvolution.cpp:4142
+  static const SCEV *rewrite(const SCEV *S, const Loop *L, ScalarEvolution &SE,
+                             bool IgnoreOtherLoops = false) {
+    SCEVPostIncRewriter Rewriter(L, SE);
sanjoy wrote:
> We don't need `IgnoreOtherLoops` right?  If so, let's remove it for now.
If I understood it correctly the idea is just to remove it for now to make  patch mostly NFC (related to D43498) and add it when we need it in "IsKnownPredicated Fix" patch. Ok, I'll do that.


More information about the llvm-commits mailing list