[PATCH] D43499: [SCEV] Introduce SCEVPostIncRewriter

[Sanjoy Das via Phabricator via llvm-commits]

sanjoy accepted this revision.
sanjoy added a comment.
This revision is now accepted and ready to land.

lgtm with minor fixes



================
Comment at: lib/Analysis/ScalarEvolution.cpp:4142
+  static const SCEV *rewrite(const SCEV *S, const Loop *L, ScalarEvolution &SE,
+                             bool IgnoreOtherLoops = false) {
+    SCEVPostIncRewriter Rewriter(L, SE);
----------------
We don't need `IgnoreOtherLoops` right?  If so, let's remove it for now.


================
Comment at: lib/Analysis/ScalarEvolution.cpp:4166
+
+  bool isValid() { return Valid; }
+
----------------
This should be called something more descriptive -- perhaps `SawLoopVariantSCEVUnknown` or something like that.

Also applies to D43498


================
Comment at: lib/Analysis/ScalarEvolution.cpp:4168
+
+  bool isSeenOtherLoops() { return SeenOtherLoops; }
+
----------------
s/isSeenOtherLoops/hasSeenOtherLoops/

Also applies to D43498


https://reviews.llvm.org/D43499