[PATCH] D43651: TableGen: Reimplement !foreach using the resolving mechanism

Artem Belevich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 23 14:55:59 PST 2018


tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.

Hooray! Now we'll have proper temp variables in !foreach !



================
Comment at: test/TableGen/foreach-leak.td:11
+// The variable name a is used both in the "inner" and in the "outer" foreach.
+// The test ensure that the inner declaration of a properly shadows the outer
+// one.
----------------
"a" should be quoted, otherwise it looks like an indefinite article.


Repository:
  rL LLVM

https://reviews.llvm.org/D43651





More information about the llvm-commits mailing list