[PATCH] D43651: TableGen: Reimplement !foreach using the resolving mechanism

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 25 07:59:32 PST 2018


nhaehnle marked an inline comment as done.
nhaehnle added inline comments.


================
Comment at: test/TableGen/foreach-leak.td:11
+// The variable name a is used both in the "inner" and in the "outer" foreach.
+// The test ensure that the inner declaration of a properly shadows the outer
+// one.
----------------
tra wrote:
> "a" should be quoted, otherwise it looks like an indefinite article.
Done locally, will commit later.


Repository:
  rL LLVM

https://reviews.llvm.org/D43651





More information about the llvm-commits mailing list