[PATCH] D43042: [MachineOperand][Target] MachineOperand::isRenamable semantics changes

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 21 13:03:28 PST 2018


qcolombet accepted this revision.
qcolombet added a comment.
This revision is now accepted and ready to land.

Hi Geoff,

LGTM.

Could you check if you could add a test case, for instance running expand post RA pseudo?
You would need a target that expands copies into something with ExtraXXXRegAlloc and I don't know if that exists.

What I have in mind is something along the lines:
renamable dst = COPY renamable src

> expand post RA pseudo
=======================

dst = TargetInstr src

(The check would be that dst and src don't have renamable after the expansion.)

Cheers,
-Quentin


Repository:
  rL LLVM

https://reviews.llvm.org/D43042





More information about the llvm-commits mailing list