[PATCH] D43004: [LNT] Set the baseline run id in flask session and not baseline id

Chris Matthews via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 13 15:26:53 PST 2018


Yep!

> On Feb 9, 2018, at 7:29 PM, Siddhesh Poyarekar <siddhesh at gotplt.org> wrote:
> 
> On Saturday 10 February 2018 04:26 AM, Chris Matthews wrote:
>> If you change the baseline key’s value, without changing the key name, clients will keep using the old value and index to the wrong baseline.
>> 
>> What is the motivation of changing this? The baseline table is used to display the baseline name in some of the pages, that would break this.
> 
> In my instance the baseline id became different from the order_id
> because of which selecting selecting baselines did not work as expected.
> 
> That said, it seems like it might be tied in to D42894, where I use the
> baseline to set baseline in the run report, which it wasn't previously
> doing.  I thought it was a bug but maybe that wasn't even supposed to
> work that way given that everything else uses baseline ID.  I'll fix up
> D42894; does that sound like the right approach?
> 
> Siddhesh



More information about the llvm-commits mailing list