[LNT] r325071 - Don't import packages in the request handlers...

[Chris Matthews via llvm-commits]

Author: cmatthews
Date: Tue Feb 13 15:36:48 2018
New Revision: 325071

URL: http://llvm.org/viewvc/llvm-project?rev=325071&view=rev
Log:
Don't import packages in the request handlers...

Package importing is slow, and this is bad style.  This speed up my
page load benchmark by 30% for graph pages.

Modified:
    lnt/trunk/lnt/server/ui/views.py

Modified: lnt/trunk/lnt/server/ui/views.py
URL: http://llvm.org/viewvc/llvm-project/lnt/trunk/lnt/server/ui/views.py?rev=325071&r1=325070&r2=325071&view=diff
==============================================================================
--- lnt/trunk/lnt/server/ui/views.py (original)
+++ lnt/trunk/lnt/server/ui/views.py Tue Feb 13 15:36:48 2018
@@ -32,16 +32,19 @@ import lnt.server.ui.util
 import lnt.util
 import lnt.util.ImportData
 import lnt.util.stats
+from lnt.external.stats import stats as ext_stats
 from lnt.server.reporting.analysis import ComparisonResult, calc_geomean
+from lnt.server.ui import util
 from lnt.server.ui.decorators import frontend, db_route, v4_route
 from lnt.server.ui.globals import db_url_for, v4_url_for
 from lnt.server.ui.util import FLASH_DANGER, FLASH_SUCCESS, FLASH_INFO
 from lnt.server.ui.util import PrecomputedCR
+from lnt.server.ui.util import baseline_key, convert_revision
 from lnt.server.ui.util import mean
-
+from lnt.testing import PASS
 from lnt.util import logger
 from lnt.util import multidict
-from lnt.server.ui.util import baseline_key, convert_revision
+from lnt.util import stats
 
 
 # http://flask.pocoo.org/snippets/62/
@@ -289,7 +292,6 @@ def v4_machine_compare(machine_id):
 def v4_machine(id):
 
     # Compute the list of associated runs, grouped by order.
-    from lnt.server.ui import util
 
     # Gather all the runs on this machine.
     session = request.session
@@ -744,10 +746,6 @@ def v4_graph_for_sample(sample_id, field
 
 @v4_route("/graph")
 def v4_graph():
-    from lnt.server.ui import util
-    from lnt.testing import PASS
-    from lnt.util import stats
-    from lnt.external.stats import stats as ext_stats
 
     session = request.session
     ts = request.get_testsuite()
@@ -949,6 +947,7 @@ def v4_graph():
         # Aggregate by revision.
         data = multidict.multidict((rev, (val, date, run_id))
                                    for val, rev, date, run_id in q).items()
+
         data.sort(key=lambda sample: convert_revision(sample[0]))
 
         graph_datum.append((test.name, data, col, field, url))
@@ -1260,8 +1259,6 @@ def v4_graph():
 
 @v4_route("/global_status")
 def v4_global_status():
-    from lnt.server.ui import util
-
     session = request.session
     ts = request.get_testsuite()
     metric_fields = sorted(list(ts.Sample.get_metric_fields()),