[PATCH] D43278: Add Xray instrumentation support to FreeBSD

[David CARLIER via Phabricator via llvm-commits]

devnexen added inline comments.


================
Comment at: lib/xray/xray_utils.cc:97
+pid_t getTid() XRAY_NEVER_INSTRUMENT {
+  pid_t tid;
+#if SANITIZER_LINUX
----------------
devnexen wrote:
> krytarowski wrote:
> > `pid_t` is linuxism where pid=tid.
> > On NetBSD it's `lwpid_t`.
> > 
> > It would be best to have a `typedef` like `uint64_t` `Tid_type` (or something similar).
> > 
> Did not know that about NetBSD, ok fair enough.
I hope that your own porting will be handy enough.


https://reviews.llvm.org/D43278