[PATCH] D43278: Add Xray instrumentation support to FreeBSD

David CARLIER via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 14 08:39:48 PST 2018


devnexen added a comment.

In https://reviews.llvm.org/D43278#1007611, @kubamracek wrote:

> The change looks good to me. In the long term, can we split out the platform-specific logic into separate files, like ASan and TSan is doing, e.g. `asan_linux.cc`, `asan_mac.cc`, etc.? `#ifdef`s are not really scalable.


I think that was what @dberris implicity saying more or less in his comment.


https://reviews.llvm.org/D43278





More information about the llvm-commits mailing list