[PATCH] D41278: [MachineCombiner] Improve debug output (NFC)

Andrew V. Tischenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 14 03:26:03 PST 2018


avt77 updated this revision to Diff 134186.
avt77 added a comment.

1. The issue with "\n" was fixed.
2. About pattern ID in output: in theory there could be several patterns for one Root and every pattern could have several alternative sequences, right? I think in this case the pattern ID will help to distinguish all these removed/substituted sequences from each other. Am I right or it's better to remove the IDs?


https://reviews.llvm.org/D41278

Files:
  lib/CodeGen/MachineCombiner.cpp
  lib/CodeGen/MachineInstr.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D41278.134186.patch
Type: text/x-patch
Size: 7178 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180214/196a86aa/attachment.bin>


More information about the llvm-commits mailing list