[PATCH] D41278: [MachineCombiner] Improve debug output (NFC)

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 14 07:53:44 PST 2018


fhahn added a comment.

> About pattern ID in output: in theory there could be several patterns for one Root and every pattern could have several alternative sequences, right? I think in this case the pattern ID will help to distinguish all these removed/substituted sequences from each other. Am I right or it's better to remove the IDs?

Right thanks!

MachineCombiner part LGTM now. I still would prefer if you submit it without the change in lib/CodeGen/MachineInstr.cpp and do that in a separate change.


https://reviews.llvm.org/D41278





More information about the llvm-commits mailing list