[PATCH] D43006: MC: store defined macros in MCContext

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 13 11:42:31 PST 2018


Roger via Phabricator <reviews at reviews.llvm.org> writes:


> +#ifndef LLVM_MC_MCASMMACRO_H
> +#define LLVM_MC_MCASMMACRO_H
> +
> +#include "llvm/MC/MCParser/MCAsmLexer.h"
> +#include <cstddef>
> +#include <cstdint>
> +#include <string>
> +#include <vector>

I don't think you need all these in this header.

LGTM with that. Do you have commit access?

Cheers,
Rafael


More information about the llvm-commits mailing list