[PATCH] D43006: MC: store defined macros in MCContext

Roger Pau Monné via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 14 00:39:30 PST 2018


On Tue, Feb 13, 2018 at 11:42:31AM -0800, Rafael Avila de Espindola wrote:
> Roger via Phabricator <reviews at reviews.llvm.org> writes:
> 
> 
> > +#ifndef LLVM_MC_MCASMMACRO_H
> > +#define LLVM_MC_MCASMMACRO_H
> > +
> > +#include "llvm/MC/MCParser/MCAsmLexer.h"
> > +#include <cstddef>
> > +#include <cstdint>
> > +#include <string>
> > +#include <vector>
> 
> I don't think you need all these in this header.

Done, I've pushed a new version to phab.

> LGTM with that. Do you have commit access?

No, could someone take care to commit this if there are no further
comments?

I'm not sure about the procedure, but would it be possible to
backport this change to the 6 branch?

Thanks, Roger.


More information about the llvm-commits mailing list