[PATCH] D43128: Introduce an API for LLDB to compute the default module cache path

[David Blaikie via llvm-commits]

Unit test?

On Fri, Feb 9, 2018 at 10:45 AM Phabricator via Phabricator via
llvm-commits <llvm-commits at lists.llvm.org> wrote:

> This revision was automatically updated to reflect the committed changes.
> Closed by commit rL324761: Introduce an API for LLDB to compute the
> default module cache path (authored by adrian, committed by ).
> Herald added a subscriber: llvm-commits.
>
> Changed prior to commit:
>   https://reviews.llvm.org/D43128?vs=133631&id=133650#toc
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D43128
>
> Files:
>   cfe/trunk/include/clang/Driver/Driver.h
>   cfe/trunk/lib/Driver/ToolChains/Clang.cpp
>
>
> Index: cfe/trunk/lib/Driver/ToolChains/Clang.cpp
> ===================================================================
> --- cfe/trunk/lib/Driver/ToolChains/Clang.cpp
> +++ cfe/trunk/lib/Driver/ToolChains/Clang.cpp
> @@ -2500,6 +2500,13 @@
>      CmdArgs.push_back("-fno-math-builtin");
>  }
>
> +void Driver::getDefaultModuleCachePath(SmallVectorImpl<char> &Result) {
> +  llvm::sys::path::system_temp_directory(/*erasedOnReboot=*/false,
> Result);
> +  llvm::sys::path::append(Result, "org.llvm.clang.");
> +  appendUserToPath(Result);
> +  llvm::sys::path::append(Result, "ModuleCache");
> +}
> +
>  static void RenderModulesOptions(Compilation &C, const Driver &D,
>                                   const ArgList &Args, const InputInfo
> &Input,
>                                   const InputInfo &Output,
> @@ -2560,10 +2567,7 @@
>        llvm::sys::path::append(Path, "modules");
>      } else if (Path.empty()) {
>        // No module path was provided: use the default.
> -      llvm::sys::path::system_temp_directory(/*erasedOnReboot=*/false,
> Path);
> -      llvm::sys::path::append(Path, "org.llvm.clang.");
> -      appendUserToPath(Path);
> -      llvm::sys::path::append(Path, "ModuleCache");
> +      Driver::getDefaultModuleCachePath(Path);
>      }
>
>      const char Arg[] = "-fmodules-cache-path=";
> Index: cfe/trunk/include/clang/Driver/Driver.h
> ===================================================================
> --- cfe/trunk/include/clang/Driver/Driver.h
> +++ cfe/trunk/include/clang/Driver/Driver.h
> @@ -572,6 +572,8 @@
>    /// no extra characters remaining at the end.
>    static bool GetReleaseVersion(StringRef Str,
>                                  MutableArrayRef<unsigned> Digits);
> +  /// Compute the default -fmodule-cache-path.
> +  static void getDefaultModuleCachePath(SmallVectorImpl<char> &Result);
>  };
>
>  /// \return True if the last defined optimization level is -Ofast.
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180212/b91a3696/attachment.html>