<div dir="ltr">Unit test?</div><br><div class="gmail_quote"><div dir="ltr">On Fri, Feb 9, 2018 at 10:45 AM Phabricator via Phabricator via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This revision was automatically updated to reflect the committed changes.<br>
Closed by commit rL324761: Introduce an API for LLDB to compute the default module cache path (authored by adrian, committed by ).<br>
Herald added a subscriber: llvm-commits.<br>
<br>
Changed prior to commit:<br>
  <a href="https://reviews.llvm.org/D43128?vs=133631&id=133650#toc" rel="noreferrer" target="_blank">https://reviews.llvm.org/D43128?vs=133631&id=133650#toc</a><br>
<br>
Repository:<br>
  rL LLVM<br>
<br>
<a href="https://reviews.llvm.org/D43128" rel="noreferrer" target="_blank">https://reviews.llvm.org/D43128</a><br>
<br>
Files:<br>
  cfe/trunk/include/clang/Driver/Driver.h<br>
  cfe/trunk/lib/Driver/ToolChains/Clang.cpp<br>
<br>
<br>
Index: cfe/trunk/lib/Driver/ToolChains/Clang.cpp<br>
===================================================================<br>
--- cfe/trunk/lib/Driver/ToolChains/Clang.cpp<br>
+++ cfe/trunk/lib/Driver/ToolChains/Clang.cpp<br>
@@ -2500,6 +2500,13 @@<br>
     CmdArgs.push_back("-fno-math-builtin");<br>
 }<br>
<br>
+void Driver::getDefaultModuleCachePath(SmallVectorImpl<char> &Result) {<br>
+  llvm::sys::path::system_temp_directory(/*erasedOnReboot=*/false, Result);<br>
+  llvm::sys::path::append(Result, "org.llvm.clang.");<br>
+  appendUserToPath(Result);<br>
+  llvm::sys::path::append(Result, "ModuleCache");<br>
+}<br>
+<br>
 static void RenderModulesOptions(Compilation &C, const Driver &D,<br>
                                  const ArgList &Args, const InputInfo &Input,<br>
                                  const InputInfo &Output,<br>
@@ -2560,10 +2567,7 @@<br>
       llvm::sys::path::append(Path, "modules");<br>
     } else if (Path.empty()) {<br>
       // No module path was provided: use the default.<br>
-      llvm::sys::path::system_temp_directory(/*erasedOnReboot=*/false, Path);<br>
-      llvm::sys::path::append(Path, "org.llvm.clang.");<br>
-      appendUserToPath(Path);<br>
-      llvm::sys::path::append(Path, "ModuleCache");<br>
+      Driver::getDefaultModuleCachePath(Path);<br>
     }<br>
<br>
     const char Arg[] = "-fmodules-cache-path=";<br>
Index: cfe/trunk/include/clang/Driver/Driver.h<br>
===================================================================<br>
--- cfe/trunk/include/clang/Driver/Driver.h<br>
+++ cfe/trunk/include/clang/Driver/Driver.h<br>
@@ -572,6 +572,8 @@<br>
   /// no extra characters remaining at the end.<br>
   static bool GetReleaseVersion(StringRef Str,<br>
                                 MutableArrayRef<unsigned> Digits);<br>
+  /// Compute the default -fmodule-cache-path.<br>
+  static void getDefaultModuleCachePath(SmallVectorImpl<char> &Result);<br>
 };<br>
<br>
 /// \return True if the last defined optimization level is -Ofast.<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>