[PATCH] D43004: [LNT] Set the baseline run id in flask session and not baseline id

[Chris Matthews via llvm-commits]

If you change the baseline key’s value, without changing the key name, clients will keep using the old value and index to the wrong baseline.

What is the motivation of changing this? The baseline table is used to display the baseline name in some of the pages, that would break this.

> On Feb 6, 2018, at 11:58 PM, Siddhesh Poyarekar via Phabricator <reviews at reviews.llvm.org> wrote:
> 
> siddhesh updated this revision to Diff 133158.
> siddhesh retitled this revision from "[LNT] Use order_id for the Baselines menu and not id" to "[LNT] Set the baseline run id in flask session and not baseline id".
> siddhesh edited the summary of this revision.
> siddhesh added a comment.
> 
> Sorry, the fix should have been in setting of baseline, not in the baseline menu itself.  Fixed and tested.
> 
> 
> Repository:
>  rL LLVM
> 
> https://reviews.llvm.org/D43004
> 
> Files:
>  lnt/server/ui/views.py
> 
> 
> Index: lnt/server/ui/views.py
> ===================================================================
> --- lnt/server/ui/views.py
> +++ lnt/server/ui/views.py
> @@ -643,7 +644,7 @@
>     if not base:
>         return abort(404)
>     flash("Baseline set to " + base.name, FLASH_SUCCESS)
> -    flask.session[baseline_key()] = id
> +    flask.session[baseline_key()] = base.order_id
> 
>     return redirect(get_redirect_target())
> 
> 
> 
> <D43004.133158.patch>