[PATCH] D43004: [LNT] Set the baseline run id in flask session and not baseline id

Siddhesh Poyarekar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 6 23:58:58 PST 2018


siddhesh updated this revision to Diff 133158.
siddhesh retitled this revision from "[LNT] Use order_id for the Baselines menu and not id" to "[LNT] Set the baseline run id in flask session and not baseline id".
siddhesh edited the summary of this revision.
siddhesh added a comment.

Sorry, the fix should have been in setting of baseline, not in the baseline menu itself.  Fixed and tested.


Repository:
  rL LLVM

https://reviews.llvm.org/D43004

Files:
  lnt/server/ui/views.py


Index: lnt/server/ui/views.py
===================================================================
--- lnt/server/ui/views.py
+++ lnt/server/ui/views.py
@@ -643,7 +644,7 @@
     if not base:
         return abort(404)
     flash("Baseline set to " + base.name, FLASH_SUCCESS)
-    flask.session[baseline_key()] = id
+    flask.session[baseline_key()] = base.order_id
 
     return redirect(get_redirect_target())
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43004.133158.patch
Type: text/x-patch
Size: 414 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180207/883fd8b8/attachment.bin>


More information about the llvm-commits mailing list