[PATCH] D42834: [RISCV] Implement c.lui immedate operand constraint

[Ana Pazos via Phabricator via llvm-commits]

apazos added inline comments.
Herald added a subscriber: kito-cheng.


================
Comment at: lib/Target/RISCV/RISCVInstrInfoC.td:52
+// c_lui_imm check the immediate range in [1, 31] or [0xfffe0, 0xfffff]
+// as RISCV GCC, the immediate will eventally encoded as [1, 63].
+def c_lui_imm : Operand<XLenVT>,
----------------
Thanks for the patch Shiva, I will launch a run to confirm  the issue is resolved.

I am confused by the RISCV GCC comment, we are not doing this for compatibility with GCC, it is following the ISA right, though the ISA description for c.lui is not very clear. For example, c.srli better describes the accepted range. Shouldn't the ISA document be updated?



Repository:
  rL LLVM

https://reviews.llvm.org/D42834