[PATCH] D42512: [X86] When using Win64 ABI, exit with error if SSE is disabled for varargs

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 7 10:55:27 PST 2018


rnk added a comment.

I wonder if it would be more general to handle this stuff earlier in the generated calling convention code, so that the use of XMM registers is conditionalized on the subtarget support. In other words, if SSE isn't available, we'd end up assigning FP values to stack locations, just as if all SSE registers had already been consumed. We could diagnose the error at that point. I think all this code is table-generated, which makes it hard to see and edit with these fixes.


Repository:
  rL LLVM

https://reviews.llvm.org/D42512





More information about the llvm-commits mailing list