[PATCH] D42980: [scudo] Allow options to be defined at compile time

[Kostya Kortchinsky via Phabricator via llvm-commits]

cryptoad planned changes to this revision.
cryptoad added inline comments.


================
Comment at: lib/scudo/scudo_flags.cpp:43
+# define SCUDO_STRINGIZE_OPTIONS(Options) SCUDO_STRINGIZE(Options)
+  return SCUDO_STRINGIZE_OPTIONS(SCUDO_DEFAULT_OPTIONS);
+#else
----------------
alekseyshl wrote:
> Totally a nit, but maybe undef SCUDO_STRINGIZE and SCUDO_STRINGIZE_OPTIONS here, as we do with SCUDO_FLAG above?
> 
> Maybe it's time to have this definition in common and use it everywhere:
> #define SANITIZER_STRINGIFY_(S) #S
> #define SANITIZER_STRINGIFY(S) SANITIZER_STRINGIFY_(S)
I'm going to move it to common.
Current users of the macro would be ASan (flags), XRay (flags), Scudo (flags) and TSan (setjmp symbols).


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D42980