[PATCH] D42980: [scudo] Allow options to be defined at compile time

[Aleksey Shlyapnikov via Phabricator via llvm-commits]

alekseyshl accepted this revision.
alekseyshl added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/scudo/scudo_flags.cpp:40
+#ifdef SCUDO_DEFAULT_OPTIONS
+// Stringize the macro value.
+# define SCUDO_STRINGIZE(x) #x
----------------
Remove this extraneous comment.


================
Comment at: lib/scudo/scudo_flags.cpp:43
+# define SCUDO_STRINGIZE_OPTIONS(Options) SCUDO_STRINGIZE(Options)
+  return SCUDO_STRINGIZE_OPTIONS(SCUDO_DEFAULT_OPTIONS);
+#else
----------------
Totally a nit, but maybe undef SCUDO_STRINGIZE and SCUDO_STRINGIZE_OPTIONS here, as we do with SCUDO_FLAG above?

Maybe it's time to have this definition in common and use it everywhere:
#define SANITIZER_STRINGIFY_(S) #S
#define SANITIZER_STRINGIFY(S) SANITIZER_STRINGIFY_(S)


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D42980