[PATCH] D42925: Call FlushFileBuffers on readwrite file mappings.

[Zachary Turner via Phabricator via llvm-commits]

zturner added inline comments.


================
Comment at: llvm/lib/Support/Windows/Path.inc:900
+      // invalid data.  Calling FlushFileBuffers on the write handle is
+      // sufficient to ensure that this bug is not triggered.
+      HANDLE FileHandle = reinterpret_cast<HANDLE>(_get_osfhandle(FD));
----------------
amccarth wrote:
> How about including the URL from the patch description directly in the comment?
I thought about it, but it would wrap past 80 characters (not a huge deal, admittedly).  More importantly though, it doesn't contain any kind of workaround or acknowledgement from Microsoft other than "we did the same thing in `link.exe`".  I was hoping that if / when we get more concrete information from someone on the kernel team that I could update it with that, since that would actually be some additional info besides what's in this comment.  That said, if anyone feels strongly, I can add it here in the meantime (although it doesn't really say much that this comment doesn't already say).


https://reviews.llvm.org/D42925