[PATCH] D42925: Call FlushFileBuffers on readwrite file mappings.

Adrian McCarthy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 5 13:00:58 PST 2018


amccarth added inline comments.


================
Comment at: llvm/lib/Support/Windows/Path.inc:900
+      // invalid data.  Calling FlushFileBuffers on the write handle is
+      // sufficient to ensure that this bug is not triggered.
+      HANDLE FileHandle = reinterpret_cast<HANDLE>(_get_osfhandle(FD));
----------------
How about including the URL from the patch description directly in the comment?


https://reviews.llvm.org/D42925





More information about the llvm-commits mailing list