[PATCH] D42582: [lldb][PPC64] Fixed step-in stopping in the wrong line

[Leandro Lupori via Phabricator via llvm-commits]

luporl updated this revision to Diff 132573.
luporl added a comment.

- Changed GetBytesToSkip comment to focus on the API

Now the first two paragraphs explain the API.
The last one is the PPC64 example.
I also moved some more specific PPC64 details to the ArchitecturePPC64 header,
making the example in the base Architecture class a bit simpler.

As @jingham pointed out, this method may need some refactoring when dealing with
breakpoints and multiple entry points. But when this time comes, we will
probably have a better view of how to improve this method.


https://reviews.llvm.org/D42582

Files:
  include/lldb/Core/Architecture.h
  source/API/SystemInitializerFull.cpp
  source/Host/common/HostInfoBase.cpp
  source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.cpp
  source/Plugins/Architecture/CMakeLists.txt
  source/Plugins/Architecture/PPC64/ArchitecturePPC64.cpp
  source/Plugins/Architecture/PPC64/ArchitecturePPC64.h
  source/Plugins/Architecture/PPC64/CMakeLists.txt
  source/Target/ThreadPlanStepInRange.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D42582.132573.patch
Type: text/x-patch
Size: 13036 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180202/b843b05d/attachment.bin>