[PATCH] D42582: [lldb][PPC64] Fixed step-in stopping in the wrong line

[Jim Ingham via Phabricator via llvm-commits]

jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.

This fix is fine for this part of the multiple entry points problem.  My guess is that when you start dealing breakpoints and multiple entry points this method will start to look ugly, and having Symbols just return their multiple entry points & prologue length from each will look nicer.  But we can address that when you get that far.

There was one comment related comment, otherwise this looks okay.



================
Comment at: include/lldb/Core/Architecture.h:53-55
+  /// called from a local context. Thus, this method should always
+  /// return the same value, regardless of the PC being at a global
+  /// or local entry point.
----------------
I don't mind using the PPC64 case as an example.  But the sentence starting with "Thus..." actually defines how the API should work, so it should be moved outside the example paragraph or it's likely to be overlooked.


https://reviews.llvm.org/D42582